Skip to content

Commit 2241a0e

Browse files
authored
fix: pin cython<3 on setup [backport #6376 to 1.15] (#6382)
Backports #6376 to 1.15. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent da12db9 commit 2241a0e

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[build-system]
2-
requires = ["setuptools >= 40.6.0", "setuptools_scm[toml] >=4,<6.1", "cython"]
2+
requires = ["setuptools >= 40.6.0", "setuptools_scm[toml] >=4,<6.1", "cython<3"]
33
build-backend = "setuptools.build_meta"
44

55
[tool.setuptools_scm]
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Pin ``cython<3`` due to an incompatibility with ``cython==3.0.0`` and typing annotations in
5+
profiling code.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ def get_exts_for(name):
491491
"Programming Language :: Python :: 3.11",
492492
],
493493
use_scm_version={"write_to": "ddtrace/_version.py"},
494-
setup_requires=["setuptools_scm[toml]>=4", "cython"],
494+
setup_requires=["setuptools_scm[toml]>=4", "cython<3"],
495495
ext_modules=ext_modules
496496
+ cythonize(
497497
[

0 commit comments

Comments
 (0)