fix(aap): path fix for django view arguments (#14268)

fixing issue #14258

Also little change to the django app for threats tests to have a
regression test.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Brett Langdon <[email protected]>

Author: christophe-papazian

ddtrace/contrib/internal/django/patch.py

@@ -667,17 +667,17 @@ def _instrument_view(django, view, path=None):
 def traced_urls_path(django, pin, wrapped, instance, args, kwargs):
     """Wrapper for url path helpers to ensure all views registered as urls are traced."""
     try:
-        from_args = False
-        view = kwargs.pop("view", None)
-        path = kwargs.pop("path", None)
-        if view is None:
+        view_from_args = False
+        view = kwargs.get("view", None)
+        path = kwargs.get("route", None)
+        if view is None and len(args) > 1:
             view = args[1]
-            from_args = True
-        if path is None:
+            view_from_args = True
+        if path is None and args:
             path = args[0]
 
         core.dispatch("service_entrypoint.patch", (unwrap(view),))
-        if from_args:
+        if view_from_args:
             args = list(args)
             args[1] = instrument_view(django, view, path=path)
             args = tuple(args)

releasenotes/notes/fixing_route_error_in_django_view-a169a77c53200055.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    AAP: This fix resolves an issue where the ``route`` parameter was not being correctly handled in the Django path function.

tests/appsec/contrib_appsec/django_app/urls.py

@@ -286,7 +286,7 @@ def shutdown(request):
         path("new_service/<str:service_name>", new_service, name="new_service"),
         path("rasp/<str:endpoint>/", rasp, name="rasp"),
         path("rasp/<str:endpoint>", rasp, name="rasp"),
-        path("login/", login_user, name="login"),
+        path(route="login/", view=login_user, name="login"),
         path("login", login_user, name="login"),
         path("login_sdk/", login_user_sdk, name="login_sdk"),
         path("login_sdk", login_user_sdk, name="login_sdk"),