Skip to content

Commit 2eee5cd

Browse files
ci: test against the latest minor release of Mako [backport 1.20] (#7827)
This pull request fixes [failures](https://github.com/DataDog/dd-trace-py/actions/runs/7085298702/job/19281284381?pr=7819) of the Mako framework test suite caused by the recent release of transitive dependency Chameleon==4.3.0 in malthe/chameleon@3f7c904. Luckily, it turns out that the latest version of Mako doesn't exhibit the same issue, so upgrading the tested version is sufficient to unblock our merges. @brettlangdon note that if we decide to merge this, someone with the permission to do so will need to update the github action requirement to reference the new framework test name. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that. --------- Co-authored-by: Alberto Vara <[email protected]>
1 parent cc3b4f7 commit 2eee5cd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/test_frameworks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ jobs:
359359
# test_pool_timeout raises RuntimeError: The connection pool was closed while 1 HTTP requests/responses were still in-flight
360360
run: pytest -k 'not test_pool_timeout'
361361

362-
mako-testsuite-1_1_4:
362+
mako-testsuite-1_3_0:
363363
runs-on: ubuntu-latest
364364
needs: needs-run
365365
env:
@@ -380,7 +380,7 @@ jobs:
380380
if: needs.needs-run.outputs.outcome == 'success'
381381
with:
382382
repository: sqlalchemy/mako
383-
ref: rel_1_1_4
383+
ref: rel_1_3_0
384384
path: mako
385385
- uses: actions/setup-python@v4
386386
if: needs.needs-run.outputs.outcome == 'success'
@@ -603,7 +603,7 @@ jobs:
603603
if: needs.needs-run.outputs.outcome == 'success'
604604
run: |
605605
. ../ddtrace/.github/workflows/setup-tox.sh py39
606-
606+
607607
pip install -e .
608608
pytest -p no:warnings -k "not test_import" tests/
609609

0 commit comments

Comments
 (0)