Skip to content

Commit 2f7ee42

Browse files
fix(grpc_aio): new version 1.48.0 has updated error message (#4013) (#4212)
## Description New version 1.48.0 of grpc has updated error message: https://github.com/grpc/grpc/releases/tag/v1.48.0 ``` > assert client_span.get_tag(ERROR_MSG) == "failed to connect to all addresses" E AssertionError: assert 'failed to co...ction refused' == 'failed to co...all addresses' E - failed to connect to all addresses E + failed to connect to all addresses; last error: UNKNOWN: Failed to connect to remote host: Connection refused ``` ## Checklist - [x] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [x] Add additional sections for `feat` and `fix` pull requests. - [x] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit c447239) Co-authored-by: Alberto Vara <[email protected]>
1 parent 68def13 commit 2f7ee42

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/contrib/grpc_aio/test_grpc_aio.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ async def test_invalid_target(server_info, tracer):
252252

253253
assert client_span.resource == "/helloworld.Hello/SayHello"
254254
assert client_span.error == 1
255-
assert client_span.get_tag(ERROR_MSG) == "failed to connect to all addresses"
255+
assert "failed to connect to all addresses" in client_span.get_tag(ERROR_MSG)
256256
assert client_span.get_tag(ERROR_TYPE) == "StatusCode.UNAVAILABLE"
257257
assert client_span.get_tag(ERROR_STACK) is None
258258

0 commit comments

Comments
 (0)