|
9 | 9 |
|
10 | 10 | from ddtrace.ext import ci |
11 | 11 | from ddtrace.ext import git |
| 12 | +from ddtrace.ext.ci import _filter_sensitive_info |
12 | 13 | from tests import utils |
13 | 14 |
|
14 | 15 |
|
@@ -72,6 +73,32 @@ def test_git_extract_repository_url(git_repo): |
72 | 73 | assert git.extract_repository_url(cwd=git_repo) == expected_repository_url |
73 | 74 |
|
74 | 75 |
|
| 76 | +def test_git_filter_repository_url_valid(): |
| 77 | + """Make sure that valid git repository urls are not filtered.""" |
| 78 | + valid_url_1 = "https://github.com/DataDog/dd-trace-py.git" |
| 79 | + valid_url_2 = "[email protected]:DataDog/dd-trace-py.git" |
| 80 | + valid_url_3 = "ssh://github.com/Datadog/dd-trace-py.git" |
| 81 | + |
| 82 | + assert _filter_sensitive_info(valid_url_1) == valid_url_1 |
| 83 | + assert _filter_sensitive_info(valid_url_2) == valid_url_2 |
| 84 | + assert _filter_sensitive_info(valid_url_3) == valid_url_3 |
| 85 | + |
| 86 | + |
| 87 | +def test_git_filter_repository_url_invalid(): |
| 88 | + """Make sure that valid git repository urls are not filtered.""" |
| 89 | + invalid_url_1 = "https://username:[email protected]/DataDog/dd-trace-py.git" |
| 90 | + invalid_url_2 = "https://[email protected]/DataDog/dd-trace-py.git" |
| 91 | + |
| 92 | + invalid_url_3 = "ssh://username:[email protected]/DataDog/dd-trace-py.git" |
| 93 | + invalid_url_4 = "ssh://[email protected]/DataDog/dd-trace-py.git" |
| 94 | + |
| 95 | + assert _filter_sensitive_info(invalid_url_1) == "https://github.com/DataDog/dd-trace-py.git" |
| 96 | + assert _filter_sensitive_info(invalid_url_2) == "https://github.com/DataDog/dd-trace-py.git" |
| 97 | + |
| 98 | + assert _filter_sensitive_info(invalid_url_3) == "ssh://github.com/DataDog/dd-trace-py.git" |
| 99 | + assert _filter_sensitive_info(invalid_url_4) == "ssh://github.com/DataDog/dd-trace-py.git" |
| 100 | + |
| 101 | + |
75 | 102 | def test_git_extract_repository_url_error(git_repo_empty): |
76 | 103 | """On error, the repository url tag should not be extracted, and should internally raise an error.""" |
77 | 104 | with pytest.raises(ValueError): |
|
0 commit comments