Skip to content

Commit 3226831

Browse files
github-actions[bot]erikayasudaavara1986
authored
ci: move promote-oci-to-prod job to release stage [backport 2.21] (#12569)
Backport 1f187eb from #12534 to 2.21. We want to ensure that no artifacts are published anywhere until the very end of the release pipeline. This was true for our PyPI pubilshing, but not for OCI images. This change will make the OCI publish job dependent on no jobs, but part of the release stage to ensure this. This was tested on [this commit](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/57265203) (temporarily added this feature branch as a valid trigger for release stage), and it successfully blocked the OCI job when the PyPI publish job failed. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <[email protected]> Co-authored-by: Alberto Vara <[email protected]>
1 parent d23c9e6 commit 3226831

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

.gitlab-ci.yml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,41 @@ requirements_json_test:
5454
package-oci:
5555
needs: [ download_dependency_wheels, download_ddtrace_artifacts ]
5656

57+
promote-oci-to-prod:
58+
stage: release
59+
rules: null
60+
only:
61+
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
62+
needs: [ release_pypi_prod ]
63+
64+
promote-oci-to-prod-beta:
65+
stage: release
66+
rules: null
67+
only:
68+
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
69+
needs: null
70+
71+
promote-oci-to-staging:
72+
stage: release
73+
rules: null
74+
only:
75+
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
76+
needs: null
77+
78+
publish-lib-init-ghcr-tags:
79+
stage: release
80+
rules: null
81+
only:
82+
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
83+
needs: [release_pypi_prod]
84+
85+
publish-lib-init-pinned-tags:
86+
stage: release
87+
rules: null
88+
only:
89+
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
90+
needs: [release_pypi_prod]
91+
5792
onboarding_tests_installer:
5893
parallel:
5994
matrix:

0 commit comments

Comments
 (0)