Skip to content

Commit 3a84c3a

Browse files
fix(dep): install cmake as setup_requires instead of install_requires [backport 1.17] (#6472)
Backport 5dc852e from #6468 to 1.17. Fixes #6467 `cmake` was added to `install_requires` instead of `setup_requires` when it isn't needed there. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <[email protected]>
1 parent fed11c0 commit 3a84c3a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
fixes:
3+
- |
4+
core: This fix moves ``cmake`` from ``install_requires`` to ``setup_requires``.

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,6 @@ def get_ddup_ext():
547547
"envier",
548548
"pep562; python_version<'3.7'",
549549
"opentelemetry-api>=1; python_version>='3.7'",
550-
"cmake>=3.24.2; python_version>='3.6'",
551550
]
552551
+ bytecode,
553552
extras_require={
@@ -585,7 +584,7 @@ def get_ddup_ext():
585584
"Programming Language :: Python :: 3.11",
586585
],
587586
use_scm_version={"write_to": "ddtrace/_version.py"},
588-
setup_requires=["setuptools_scm[toml]>=4", "cython<3"],
587+
setup_requires=["setuptools_scm[toml]>=4", "cython<3", "cmake>=3.24.2; python_version>='3.6'"],
589588
ext_modules=ext_modules
590589
+ cythonize(
591590
[

0 commit comments

Comments
 (0)