fix(profiling/heap): use the right integer type to iterate over freezer frees (backport #3174) (#3176)

This is an automatic backport of pull request #3174 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Author: mergify[bot]

ddtrace/profiling/collector/_memalloc_heap.c

@@ -103,7 +103,7 @@ heap_tracker_thaw(heap_tracker_t* heap_tracker)
        array together to be sure that there's no free in the freezer matching
        an alloc that is also in the freezer; heap_tracker_untrack_thawed does
        not care about the freezer, by definition. */
-    for (TRACEBACK_ARRAY_COUNT_TYPE i = 0; i < heap_tracker->freezer.frees.count; i++)
+    for (MEMALLOC_HEAP_PTR_ARRAY_COUNT_TYPE i = 0; i < heap_tracker->freezer.frees.count; i++)
         heap_tracker_untrack_thawed(heap_tracker, heap_tracker->freezer.frees.tab[i]);
 
     /* Reset the count to zero so we can reused the array and overwrite previous values */
@@ -149,9 +149,9 @@ memalloc_heap_untrack(void* ptr)
            enough space, we ignore the untrack. That's sad as there is a change
            the heap profile won't be valid anymore. However, that's the best we
            can do since reporting an error is not an option here. What's gonna
-           free more than 2^64 pointer anyway?!
+           free more than 2^64 pointers anyway?!
         */
-        if (global_heap_tracker.freezer.frees.count < MEMALLOC_HEAP_PTR_ARRAY_MAX)
+        if (global_heap_tracker.freezer.frees.count < MEMALLOC_HEAP_PTR_ARRAY_MAX_COUNT)
             ptr_array_append(&global_heap_tracker.freezer.frees, ptr);
     } else
         heap_tracker_untrack_thawed(&global_heap_tracker, ptr);

ddtrace/profiling/collector/_memalloc_heap.h

@@ -25,7 +25,8 @@ memalloc_heap_track(uint16_t max_nframe, void* ptr, size_t size);
 void
 memalloc_heap_untrack(void* ptr);
 
-#define MEMALLOC_HEAP_PTR_ARRAY_MAX UINT64_MAX
-DO_ARRAY(void *, ptr, uint64_t, DO_NOTHING)
+#define MEMALLOC_HEAP_PTR_ARRAY_COUNT_TYPE uint64_t
+#define MEMALLOC_HEAP_PTR_ARRAY_MAX_COUNT UINT64_MAX
+DO_ARRAY(void *, ptr, MEMALLOC_HEAP_PTR_ARRAY_COUNT_TYPE, DO_NOTHING)
 
 #endif

releasenotes/notes/profielr-heap-iterate-freezer-frees-a366cc6dbeadd188.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Fix a bug in the heap profiler that could be triggered if more than 2^16
+    memory items were freed during heap data collection.