Skip to content

Commit 47bfb24

Browse files
committed
Separate service and trace tests
1 parent 7433d8b commit 47bfb24

File tree

1 file changed

+15
-9
lines changed

1 file changed

+15
-9
lines changed

tests/contrib/django/test_tracing_disabled.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,30 @@
1111

1212

1313
class DjangoTracingDisabledTest(TestCase):
14-
def test_nothing_is_written(self):
14+
def setUp(self):
1515
tracer = Tracer()
1616
tracer.writer = DummyWriter()
17+
self.tracer = tracer
1718
# Backup the old conf
18-
backupTracer = settings.TRACER
19-
backupEnabled = settings.ENABLED
19+
self.backupTracer = settings.TRACER
20+
self.backupEnabled = settings.ENABLED
2021
# Disable tracing
2122
settings.ENABLED = False
2223
settings.TRACER = tracer
2324
# Restart the app
2425
app = apps.get_app_config('datadog_django')
2526
app.ready()
2627

27-
traces = tracer.writer.pop_traces()
28-
assert len(traces) == 0
29-
services = tracer.writer.pop_services()
28+
def tearDown(self):
29+
# Reset the original settings
30+
settings.ENABLED = self.backupEnabled
31+
settings.TRACER = self.backupTracer
32+
33+
def test_no_service_info_is_written(self):
34+
services = self.tracer.writer.pop_services()
3035
assert len(services) == 0
3136

32-
# Reset the original settings
33-
settings.ENABLED = backupEnabled
34-
settings.TRACER = backupTracer
37+
def test_no_trace_is_written(self):
38+
settings.TRACER.trace("client.testing").finish()
39+
traces = self.tracer.writer.pop_traces()
40+
assert len(traces) == 0

0 commit comments

Comments
 (0)