You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci: pin testrunner to test py<3.7 [targets 1.20] (#7767)
## Description
This PR pins the version of testrunner used in the 1.20 branch. This
will allow us to run tests with `python<=3.6`.
## Motivation
The latest testrunner image does not support python<3.7
([image](https://github.com/datadog/dd-trace-py/pkgs/container/dd-trace-py%2Ftestrunner/150490464?tag=253febbef2d235970f1c71ced77df6fe4fbeb449)):
`command`: `docker run -it ghcr.io/datadog/dd-trace-py/testrunner:latest
cat root/.python-version`
`output`: `3.10.11 3.7.16 3.8.16 3.9.16 3.11.3 3.12-dev`
The second most recent version of testrunner supports `py<3.7`
([image](https://github.com/datadog/dd-trace-py/pkgs/container/dd-trace-py%2Ftestrunner/141140913?tag=0f49c377e3568020d82e8fa2b4f314900deb8f8d)):
`command`: `docker run -it
ghcr.io/datadog/dd-trace-py/testrunner:0f49c377e3568020d82e8fa2b4f314900deb8f8d
cat root/.python-version`
`output`: `3.10.11 2.7.18 3.5.10 3.6.15 3.7.16 3.8.16 3.9.16 3.11.3
3.12-dev`
## Checklist
- [ ] Change(s) are motivated and described in the PR description.
- [ ] Testing strategy is described if automated tests are not included
in the PR.
- [ ] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [ ] Change is maintainable (easy to change, telemetry, documentation).
- [ ] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [ ] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [ ] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [ ] Title is accurate.
- [ ] No unnecessary changes are introduced.
- [ ] Description motivates each change.
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [ ] Testing strategy adequately addresses listed risk(s).
- [ ] Change is maintainable (easy to change, telemetry, documentation).
- [ ] Release note makes sense to a user of the library.
- [ ] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [ ] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [ ] This PR doesn't touch any of that.
---------
Co-authored-by: Munir Abdinur <[email protected]>
Co-authored-by: Munir Abdinur <[email protected]>
0 commit comments