Skip to content

Commit 4d4b22f

Browse files
fix(iast): false positives outside client code [backport 2.9] (#9197)
Backport 0c7b9ca from #9176 to 2.9. If the vulnerability is outside client code, skip the vulnerability ![image](https://github.com/DataDog/dd-trace-py/assets/6352942/f7d9613a-b787-403a-ae99-e790a21b2a35) ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Alberto Vara <[email protected]>
1 parent dc75eab commit 4d4b22f

File tree

1 file changed

+1
-1
lines changed
  • ddtrace/appsec/_iast/taint_sinks

1 file changed

+1
-1
lines changed

ddtrace/appsec/_iast/taint_sinks/_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def report(cls, evidence_value="", value_parts=None, sources=None):
135135
skip_location = getattr(cls, "skip_location", False)
136136
if not skip_location:
137137
frame_info = get_info_frame(CWD)
138-
if not frame_info:
138+
if not frame_info or frame_info[0] == "" or frame_info[0] == -1:
139139
return None
140140

141141
file_name, line_number = frame_info

0 commit comments

Comments
 (0)