Skip to content

Commit 4e49390

Browse files
chore: pin setuptools_scm [backport 1.19] (#7008)
Backport bc10daf from #7005 to 1.19. This change pins setuptools_scm below version 8, which dropped support for Python versions <=3.6. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that. Co-authored-by: Emmett Butler <[email protected]>
1 parent e16a554 commit 4e49390

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[build-system]
2-
requires = ["setuptools_scm[toml]>=4", "cython<3", "cmake>=3.24.2; python_version>='3.6'"]
2+
requires = ["setuptools_scm[toml]>=4,<8", "cython<3", "cmake>=3.24.2; python_version>='3.6'"]
33
build-backend = "setuptools.build_meta"
44

55
[project]

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import sys
77
import tarfile
88

9-
109
from setuptools import Extension, find_packages, setup # isort: skip
1110
from setuptools.command.build_ext import build_ext # isort: skip
1211
from setuptools.command.build_py import build_py as BuildPyCommand # isort: skip
@@ -17,8 +16,8 @@
1716
try:
1817
# ORDER MATTERS
1918
# Import this after setuptools or it will fail
20-
from Cython.Build import cythonize # noqa: I100
2119
import Cython.Distutils
20+
from Cython.Build import cythonize # noqa: I100
2221
except ImportError:
2322
raise ImportError(
2423
"Failed to import Cython modules. This can happen under versions of pip older than 18 that don't "
@@ -594,7 +593,7 @@ def get_ddup_ext():
594593
"Programming Language :: Python :: 3.10",
595594
"Programming Language :: Python :: 3.11",
596595
],
597-
setup_requires=["setuptools_scm[toml]>=4", "cython<3", "cmake>=3.24.2; python_version>='3.6'"],
596+
setup_requires=["setuptools_scm[toml]>=4,<8", "cython<3", "cmake>=3.24.2; python_version>='3.6'"],
598597
ext_modules=ext_modules
599598
+ cythonize(
600599
[

0 commit comments

Comments
 (0)