Skip to content

Commit 5190cb4

Browse files
authored
Update internal imports (#2986)
As we've been deprecating a lot of stuff it's important that we actually change our own code over to use the internal definitions to avoid deprecation warnings. We've had a few imports/usages slip through so let's add a regression test and fix those up.
1 parent 0373deb commit 5190cb4

File tree

136 files changed

+234
-240
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

136 files changed

+234
-240
lines changed

ddtrace/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from .monkey import patch # noqa: E402
2-
from .monkey import patch_all
1+
from ._monkey import patch # noqa: E402
2+
from ._monkey import patch_all
3+
from .internal.utils.deprecation import deprecated # noqa: E402
34
from .pin import Pin # noqa: E402
45
from .settings import _config as config # noqa: E402
56
from .span import Span # noqa: E402
67
from .tracer import Tracer # noqa: E402
7-
from .utils.deprecation import deprecated # noqa: E402
88
from .version import get_version
99

1010

ddtrace/_monkey.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
from ddtrace.vendor.wrapt.importer import when_imported
1010

1111
from .internal.logger import get_logger
12+
from .internal.utils import formats
13+
from .internal.utils.deprecation import deprecated
1214
from .settings import _config as config
13-
from .utils import formats
14-
from .utils.deprecation import deprecated
1515

1616

1717
log = get_logger(__name__)

ddtrace/context.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from .constants import SAMPLING_PRIORITY_KEY
99
from .internal.compat import NumericType
1010
from .internal.logger import get_logger
11-
from .utils.deprecation import deprecated
11+
from .internal.utils.deprecation import deprecated
1212

1313

1414
if TYPE_CHECKING:

ddtrace/contrib/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
from ..utils.importlib import func_name # noqa
2-
from ..utils.importlib import module_name # noqa
3-
from ..utils.importlib import require_modules # noqa
1+
from ..internal.utils.importlib import func_name # noqa
2+
from ..internal.utils.importlib import module_name # noqa
3+
from ..internal.utils.importlib import require_modules # noqa

ddtrace/contrib/aiobotocore/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# This query generates a trace
1919
lambda_client.list_functions()
2020
"""
21-
from ...utils.importlib import require_modules
21+
from ...internal.utils.importlib import require_modules
2222

2323

2424
required_modules = ["aiobotocore.client"]

ddtrace/contrib/aiobotocore/patch.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
from ...ext import aws
1717
from ...ext import http
1818
from ...internal.compat import PYTHON_VERSION_INFO
19+
from ...internal.utils import ArgumentError
20+
from ...internal.utils import get_argument_value
21+
from ...internal.utils.formats import deep_getattr
1922
from ...pin import Pin
20-
from ...utils import ArgumentError
21-
from ...utils import get_argument_value
22-
from ...utils.formats import deep_getattr
23-
from ...utils.wrappers import unwrap
23+
from ..trace_utils import unwrap
2424

2525

2626
ARGS_NAME = ("action", "params", "path", "verb")

ddtrace/contrib/aiohttp/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ async def home_handler(request):
4747
:ref:`All HTTP tags <http-tagging>` are supported for this integration.
4848
4949
"""
50-
from ...utils.importlib import require_modules
50+
from ...internal.utils.importlib import require_modules
5151

5252

5353
required_modules = ["aiohttp"]

ddtrace/contrib/aiohttp/patch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
from ddtrace.internal.logger import get_logger
33
from ddtrace.vendor import wrapt
44

5+
from ...internal.utils.wrappers import unwrap
56
from ...pin import Pin
6-
from ...utils.wrappers import unwrap
77

88

99
log = get_logger(__name__)

ddtrace/contrib/aiohttp/template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from ddtrace import Pin
44

55
from ...ext import SpanTypes
6-
from ...utils import get_argument_value
6+
from ...internal.utils import get_argument_value
77

88

99
def _trace_render_template(func, module, args, kwargs):

ddtrace/contrib/aiopg/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Use a pin to specify metadata related to this connection
1616
Pin.override(db, service='postgres-users')
1717
"""
18-
from ...utils.importlib import require_modules
18+
from ...internal.utils.importlib import require_modules
1919

2020

2121
required_modules = ["aiopg"]

0 commit comments

Comments
 (0)