Skip to content

Commit 5fab0c1

Browse files
authored
chore(propagation): add context span links to span correctly (#7658)
Not a fix because this feature hasn't been released yet. The logic before was incorrect, because we never would have context span links at that point. This also adds a test using fastapi to assure our root span actually has the links added correctly, while child spans do not. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Title is accurate. - [ ] No unnecessary changes are introduced. - [ ] Description motivates each change. - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Testing strategy adequately addresses listed risk(s). - [ ] Change is maintainable (easy to change, telemetry, documentation). - [ ] Release note makes sense to a user of the library. - [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [ ] This PR doesn't touch any of that.
1 parent 0c14b3a commit 5fab0c1

21 files changed

+344
-188
lines changed

.riot/requirements/19de4fb.txt

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
#
2+
# This file is autogenerated by pip-compile with Python 3.12
3+
# by the following command:
4+
#
5+
# pip-compile --no-annotate .riot/requirements/19de4fb.in
6+
#
7+
annotated-types==0.6.0
8+
anyio==3.7.1
9+
attrs==23.1.0
10+
certifi==2023.7.22
11+
coverage[toml]==7.3.2
12+
fastapi==0.104.1
13+
h11==0.14.0
14+
httpcore==1.0.2
15+
httpretty==1.1.4
16+
httpx==0.25.1
17+
hypothesis==6.45.0
18+
idna==3.4
19+
iniconfig==2.0.0
20+
mock==5.1.0
21+
msgpack==1.0.7
22+
opentracing==2.4.0
23+
packaging==23.2
24+
pluggy==1.3.0
25+
pydantic==2.5.1
26+
pydantic-core==2.14.3
27+
pytest==7.4.3
28+
pytest-cov==4.1.0
29+
pytest-mock==3.12.0
30+
sniffio==1.3.0
31+
sortedcontainers==2.4.0
32+
starlette==0.27.0
33+
structlog==23.2.0
34+
typing-extensions==4.8.0
35+
wheel==0.41.3

.riot/requirements/1bd153a.txt

Lines changed: 0 additions & 22 deletions
This file was deleted.

.riot/requirements/1a8dea8.txt renamed to .riot/requirements/1c3e1e3.txt

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,38 @@
22
# This file is autogenerated by pip-compile with Python 3.7
33
# by the following command:
44
#
5-
# pip-compile --config=pyproject.toml --no-annotate --resolver=backtracking .riot/requirements/1a8dea8.in
5+
# pip-compile --config=pyproject.toml --no-annotate --resolver=backtracking .riot/requirements/1c3e1e3.in
66
#
7+
annotated-types==0.5.0
8+
anyio==3.7.1
79
attrs==23.1.0
10+
certifi==2023.7.22
811
coverage[toml]==7.2.7
912
exceptiongroup==1.1.3
13+
fastapi==0.103.2
14+
h11==0.14.0
15+
httpcore==0.17.3
1016
httpretty==1.1.4
17+
httpx==0.24.1
1118
hypothesis==6.45.0
19+
idna==3.4
1220
importlib-metadata==6.7.0
1321
iniconfig==2.0.0
1422
mock==5.1.0
1523
msgpack==1.0.5
1624
opentracing==2.4.0
17-
packaging==23.1
25+
packaging==23.2
1826
pluggy==1.2.0
19-
pytest==7.4.0
27+
pydantic==2.5.1
28+
pydantic-core==2.14.3
29+
pytest==7.4.3
2030
pytest-cov==4.1.0
2131
pytest-mock==3.11.1
32+
sniffio==1.3.0
2233
sortedcontainers==2.4.0
34+
starlette==0.27.0
2335
structlog==23.1.0
2436
tomli==2.0.1
2537
typing-extensions==4.7.1
26-
wheel==0.41.2
38+
wheel==0.41.3
2739
zipp==3.15.0

.riot/requirements/1c83510.txt

Lines changed: 0 additions & 22 deletions
This file was deleted.

.riot/requirements/1cade2e.txt

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
#
2+
# This file is autogenerated by pip-compile with Python 3.12
3+
# by the following command:
4+
#
5+
# pip-compile --no-annotate .riot/requirements/1cade2e.in
6+
#
7+
annotated-types==0.6.0
8+
anyio==3.7.1
9+
attrs==23.1.0
10+
certifi==2023.7.22
11+
coverage[toml]==7.3.2
12+
fastapi==0.104.1
13+
h11==0.14.0
14+
httpcore==1.0.2
15+
httpretty==1.1.4
16+
httpx==0.25.1
17+
hypothesis==6.45.0
18+
idna==3.4
19+
iniconfig==2.0.0
20+
mock==5.1.0
21+
msgpack==1.0.7
22+
opentracing==2.4.0
23+
packaging==23.2
24+
pluggy==1.3.0
25+
pydantic==2.5.1
26+
pydantic-core==2.14.3
27+
pytest==7.4.3
28+
pytest-cov==4.1.0
29+
pytest-mock==3.12.0
30+
sniffio==1.3.0
31+
sortedcontainers==2.4.0
32+
starlette==0.27.0
33+
structlog==23.2.0
34+
typing-extensions==4.8.0
35+
wheel==0.41.3

.riot/requirements/1d15302.txt

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
#
2+
# This file is autogenerated by pip-compile with Python 3.9
3+
# by the following command:
4+
#
5+
# pip-compile --no-annotate .riot/requirements/1d15302.in
6+
#
7+
annotated-types==0.6.0
8+
anyio==3.7.1
9+
attrs==23.1.0
10+
certifi==2023.7.22
11+
coverage[toml]==7.3.2
12+
exceptiongroup==1.1.3
13+
fastapi==0.104.1
14+
h11==0.14.0
15+
httpcore==1.0.2
16+
httpretty==1.1.4
17+
httpx==0.25.1
18+
hypothesis==6.45.0
19+
idna==3.4
20+
iniconfig==2.0.0
21+
mock==5.1.0
22+
msgpack==1.0.7
23+
opentracing==2.4.0
24+
packaging==23.2
25+
pluggy==1.3.0
26+
pydantic==2.5.1
27+
pydantic-core==2.14.3
28+
pytest==7.4.3
29+
pytest-cov==4.1.0
30+
pytest-mock==3.12.0
31+
sniffio==1.3.0
32+
sortedcontainers==2.4.0
33+
starlette==0.27.0
34+
structlog==23.2.0
35+
tomli==2.0.1
36+
typing-extensions==4.8.0
37+
wheel==0.41.3

.riot/requirements/6126a3f.txt

Lines changed: 0 additions & 22 deletions
This file was deleted.

.riot/requirements/640620a.txt

Lines changed: 0 additions & 24 deletions
This file was deleted.

.riot/requirements/6e1a0eb.txt

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
#
2+
# This file is autogenerated by pip-compile with Python 3.10
3+
# by the following command:
4+
#
5+
# pip-compile --no-annotate .riot/requirements/6e1a0eb.in
6+
#
7+
annotated-types==0.6.0
8+
anyio==3.7.1
9+
attrs==23.1.0
10+
certifi==2023.7.22
11+
coverage[toml]==7.3.2
12+
exceptiongroup==1.1.3
13+
fastapi==0.104.1
14+
h11==0.14.0
15+
httpcore==1.0.2
16+
httpretty==1.1.4
17+
httpx==0.25.1
18+
hypothesis==6.45.0
19+
idna==3.4
20+
iniconfig==2.0.0
21+
mock==5.1.0
22+
msgpack==1.0.7
23+
opentracing==2.4.0
24+
packaging==23.2
25+
pluggy==1.3.0
26+
pydantic==2.5.1
27+
pydantic-core==2.14.3
28+
pytest==7.4.3
29+
pytest-cov==4.1.0
30+
pytest-mock==3.12.0
31+
sniffio==1.3.0
32+
sortedcontainers==2.4.0
33+
starlette==0.27.0
34+
structlog==23.2.0
35+
tomli==2.0.1
36+
typing-extensions==4.8.0
37+
wheel==0.41.3

.riot/requirements/72f9106.txt

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)