fix(botocore): exclude params.Records from tags (#2204)

P403n1x87 · jd · mergify[bot] · web-flow · commit 66eab83a995d · 2021-03-23T15:04:44.000Z
* fix(botocore): exclude params.Records from tags

The params.Records argument could be big and therefore generate big
trace payloads when added to the span tags. This change marks this
argument for exclusion.

* Update releasenotes/notes/botocore-exclude-records--74ac3e5d4d4fdc95.yaml

Co-authored-by: Julien Danjou &lt;julien@danjou.info&gt;

Co-authored-by: Julien Danjou &lt;julien@danjou.info&gt;
Co-authored-by: mergify[bot] &lt;37929162+mergify[bot]@users.noreply.github.com&gt;
Co-authored-by: Julien Danjou &lt;julien.danjou@datadoghq.com&gt;
Co-authored-by: Kyle Verhoog &lt;kyle@verhoog.ca&gt;
diff --git a/ddtrace/ext/aws.py b/ddtrace/ext/aws.py
@@ -13,6 +13,7 @@
 EXCLUDED_ENDPOINT = {"kms", "sts"}
 EXCLUDED_ENDPOINT_TAGS = {
     "s3": {"params.Body"},
+    "firehose": {"params.Records"},
 }
 
 
diff --git a/docs/spelling_wordlist.txt b/docs/spelling_wordlist.txt
@@ -38,6 +38,7 @@ entrypoint
 entrypoints
 Fargate
 fastapi
+Firehose
 gRPC
 gevent
 greenlet
diff --git a/releasenotes/notes/botocore-exclude-records--74ac3e5d4d4fdc95.yaml b/releasenotes/notes/botocore-exclude-records--74ac3e5d4d4fdc95.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    The ``Records`` parameter to ``Firehose`` endpoint calls is being excluded from the
+    tags to avoid generating traces with a large payload.

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`EXCLUDED_ENDPOINT = {"kms", "sts"}`
`14`	`14`	`EXCLUDED_ENDPOINT_TAGS = {`
`15`	`15`	`"s3": {"params.Body"},`
	`16`	`+ "firehose": {"params.Records"},`
`16`	`17`	`}`
`17`	`18`
`18`	`19`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +fixes:
 +  - |
 +    The ``Records`` parameter to ``Firehose`` endpoint calls is being excluded from the
 +    tags to avoid generating traces with a large payload.