Skip to content

Commit 682b7f0

Browse files
authored
Improve error logging for dropped traces
This error message is vague and does not provide enough action items or information for investigation. ``` log.error("dropped more traces than accepted (dropped: %d, accepted: %d)", dropped, accepted) ```
1 parent 8cd71af commit 682b7f0

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

ddtrace/internal/writer.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,12 @@ def _set_drop_rate(self):
324324

325325
if dropped > accepted:
326326
# Sanity check, we cannot drop more traces than we accepted.
327-
log.error("dropped more traces than accepted (dropped: %d, accepted: %d)", dropped, accepted)
328-
327+
log.debug(
328+
"dropped.traces metric is greater than accepted.traces metric"
329+
"This difference may be reconciled in future metric uploads (dropped.traces: %d, accepted.traces: %d)",
330+
dropped,
331+
accepted,
332+
)
329333
accepted = dropped
330334

331335
self._drop_sma.set(dropped, accepted)

0 commit comments

Comments
 (0)