Skip to content

Commit 6932159

Browse files
authored
chore(build): turn off extension hash cache on 3.10 (#14367)
Multiple PRs experienced `tests/smoke_test.py` failing on build_base_venv jobs, blocking merging those PRs, examples include - #14310 - #14353 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 47b9f8e commit 6932159

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

.gitlab/templates/cached-testrunner.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,16 @@
1818
else
1919
source $EXT_CACHE_VENV/bin/activate
2020
fi
21-
python scripts/gen_ext_cache_scripts.py
22-
deactivate
23-
$SHELL scripts/restore-ext-cache.sh
24-
after_script: |
25-
set -e -o pipefail
26-
source $EXT_CACHE_VENV/bin/activate
27-
python scripts/gen_ext_cache_scripts.py
28-
deactivate
29-
$SHELL scripts/save-ext-cache.sh
21+
# Turn off ext build cache as it makes smoke_test very flaky on 3.10
22+
# python scripts/gen_ext_cache_scripts.py
23+
# deactivate
24+
# $SHELL scripts/restore-ext-cache.sh
25+
# after_script: |
26+
# set -e -o pipefail
27+
# source $EXT_CACHE_VENV/bin/activate
28+
# python scripts/gen_ext_cache_scripts.py
29+
# deactivate
30+
# $SHELL scripts/save-ext-cache.sh
3031
cache:
3132
# Share pip/sccache between jobs of the same Python version
3233
- key: v1-build_base_venvs-${{PYTHON_VERSION}}-cache-{current_month}

0 commit comments

Comments
 (0)