Skip to content

Commit 6a238f8

Browse files
authored
chore(ci): update tested versions of rq (#4919)
## Description `rq` released 1.12.0 which dropped support for Python 3.5, but did not update the `python_requires` in `setup.py` to reflect this. This means it is possible to install 1.12.0 on Python 3.5, which will not work. rq/rq#1755 I also updated the overall tested versions of `rq` since the current pattern is fairly (unnecessarily?) verbose. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio.
1 parent f7057df commit 6a238f8

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

riotfile.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,8 +1702,6 @@ def select_pys(min_version=MIN_PYTHON_VERSION, max_version=MAX_PYTHON_VERSION):
17021702
pkgs={
17031703
"rq": [
17041704
"~=1.0.0",
1705-
"~=1.1.0",
1706-
"~=1.2.0",
17071705
"~=1.3.0",
17081706
],
17091707
},
@@ -1713,16 +1711,19 @@ def select_pys(min_version=MIN_PYTHON_VERSION, max_version=MAX_PYTHON_VERSION):
17131711
pkgs={
17141712
"rq": [
17151713
"~=1.0.0",
1716-
"~=1.1.0",
1717-
"~=1.2.0",
1718-
"~=1.3.0",
1719-
"~=1.4.0",
1720-
"~=1.5.0",
1721-
"~=1.6.0",
1722-
"~=1.7.0",
1723-
"~=1.8.0",
1724-
"~=1.9.0",
1725-
"~=1.10.0",
1714+
"~=1.11.0",
1715+
# 1.12.0 removed support for Python 3.5
1716+
],
1717+
# https://github.com/rq/rq/issues/1469 rq [1.0,1.8] is incompatible with click 8.0+
1718+
"click": "==7.1.2",
1719+
},
1720+
),
1721+
Venv(
1722+
pys=select_pys(min_version="3.6"),
1723+
pkgs={
1724+
"rq": [
1725+
"~=1.0.0",
1726+
"~=1.11.0",
17261727
latest,
17271728
],
17281729
# https://github.com/rq/rq/issues/1469 rq [1.0,1.8] is incompatible with click 8.0+

0 commit comments

Comments
 (0)