Skip to content

Commit 6c1ec97

Browse files
authored
ci(gunicorn): ensure tests are correctly parallelized [backport #5922 to 1.13] (#5925)
Backport of #5922 to 1.13 Currently all gunicorn tests are run 4 times ([link](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/36115/workflows/ba450883-49a6-41a8-86ba-c9642e76570e/jobs/2438853)). This change ensure gunicorn tests are split up across four runners and each test is run once. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] OPTIONAL: PR description includes explicit acknowledgement of the performance implications of the change as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
1 parent d6f4ff5 commit 6c1ec97

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

.circleci/config.yml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -648,19 +648,12 @@ jobs:
648648

649649
gunicorn:
650650
<<: *machine_executor
651-
parallelism: 4
651+
parallelism: 6
652652
steps:
653-
- attach_workspace:
654-
at: .
655-
- checkout
656-
- start_docker_services:
657-
services: ddagent
658-
- run:
659-
environment:
660-
RIOT_RUN_RECOMPILE_REQS: "<< pipeline.parameters.riot_run_latest >>"
661-
command: |
662-
mv .riot .ddriot
663-
./scripts/ddtest riot -v run --pass-env -s 'gunicorn'
653+
- run_test:
654+
pattern: "gunicorn"
655+
snapshot: true
656+
docker_services: 'ddagent'
664657

665658
httplib:
666659
<<: *machine_executor

0 commit comments

Comments
 (0)