You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(profiling): wrap del with try/except [backport 3.2] (#12839)
Backport 5c8fb46 from #12833 to 3.2.
```Python
start = None
if hasattr(self, "_self_acquired_at"):
# _self_acquired_at is only set when the acquire was captured
# if it's not set, we're not capturing the release
start = self._self_acquired_at
del self._self_acquired_at
```
Above code can raise an `AttributeError`, if there are multiple threads
calling on `release()`. Though in such scenarios, except for the thread
which actually held and released the lock, such threads would result in
a `RuntimeError`, the current behavior makes customers blame our code
instead of theirs.
The following code, by @nsrip-dd, can be used to check whether the code
raises an error or not
```Python
import threading
import sys
sys.setswitchinterval(0.0000001)
def unlock(l):
try:
l.release()
except RuntimeError:
pass
except Exception as e:
raise e
while True:
l = threading.Lock()
l.acquire()
threads = [threading.Thread(target=unlock, args=[l,]) for _ in range(64)]
for t in threads:
t.start()
for t in threads:
t.join()
```
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Co-authored-by: Taegyun Kim <[email protected]>
0 commit comments