fix(botocore): allow non-url SQS "queue urls" [backport 1.14] (#6106)

Backport 24e98d0 from #6102 to 1.14.

This change fixes #6053,
introduced in #5413, by
avoiding attempts to parse non-URL `QueueUrl` attributes from botocore
SQS payloads as URLs.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](../docs/contributing.rst#release-branch-maintenance))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](../docs/contributing.rst#release-branch-maintenance)

Co-authored-by: Emmett Butler <[email protected]>

Author: github-actions[bot]

ddtrace/ext/aws.py

@@ -91,7 +91,7 @@ def _add_api_param_span_tags(span, endpoint_name, params):
     elif endpoint_name == "sqs":
         queue_name = params.get("QueueName", "")
         queue_url = params.get("QueueUrl")
-        if queue_url:
+        if queue_url and (queue_url.startswith("sqs:") or queue_url.startswith("http")):
             # example queue_url: https://sqs.sa-east-1.amazonaws.com/12345678/queuename
             queue_name = queue_url.split("/")[-1]
             aws_account = queue_url.split("/")[-2]

releasenotes/notes/botocore-sqs-queue-nonurl-b11745018c92ea1b.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    botocore: This fix resolves an issue where ddtrace attempted to parse as URLs SQS QueueUrl attributes that
+    were not well-formed URLs.

tests/contrib/botocore/test.py

@@ -384,6 +384,22 @@ def test_sqs_send_message_trace_injection_with_no_message_attributes(self):
             assert trace_data_in_message[HTTP_HEADER_TRACE_ID] == str(span.trace_id)
             assert trace_data_in_message[HTTP_HEADER_PARENT_ID] == str(span.span_id)
 
+    @mock_sqs
+    def test_sqs_send_message_non_url_queue(self):
+        with self.override_config("botocore", dict(tag_all_params=True)):
+            sqs = self.session.create_client("sqs", region_name="us-east-1", endpoint_url="http://localhost:4566")
+            queue = sqs.create_queue(QueueName="test")
+            Pin(service=self.TEST_SERVICE, tracer=self.tracer).onto(sqs)
+
+            sqs.send_message(QueueUrl="test", MessageBody="world")
+            spans = self.get_spans()
+            assert spans
+            span = spans[0]
+            assert len(spans) == 1
+            assert span.get_tag("aws.operation") == "SendMessage"
+            assert span.resource == "sqs.sendmessage"
+            sqs.delete_queue(QueueUrl=queue["QueueUrl"])
+
     @mock_sqs
     def test_sqs_send_message_distributed_tracing_off(self):
         # DEV: Only test deprecated behavior because this inspect span tags for MessageAttributes