Skip to content

Commit 8874774

Browse files
fix: set_meta and set_metas deprecation warnings (#3325) (#3327)
(cherry picked from commit 326ef73) Co-authored-by: Munir Abdinur <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 56bdb95 commit 8874774

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

ddtrace/span.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
from .internal.compat import time_ns
4242
from .internal.logger import get_logger
4343
from .vendor.debtcollector import deprecate
44+
from .vendor.debtcollector.removals import remove
4445
from .vendor.debtcollector.removals import removed_property
4546

4647

@@ -394,12 +395,12 @@ def meta(self):
394395
def meta(self, value):
395396
self._meta = value
396397

397-
@removed_property(message="Use Span.set_tag instead.", removal_version="1.0.0")
398+
@remove(message="Use Span.set_tag instead.", removal_version="1.0.0")
398399
def set_meta(self, k, v):
399400
# type: (_TagNameType, NumericType) -> None
400401
self.set_tag(k, v)
401402

402-
@removed_property(message="Use Span.set_tags.", removal_version="1.0.0")
403+
@remove(message="Use Span.set_tags.", removal_version="1.0.0")
403404
def set_metas(self, kvs):
404405
# type: (_MetaDictType) -> None
405406
self.set_tags(kvs)

tests/tracer/test_span.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,16 @@ def test_set_tag_bool(self):
8686
assert d["meta"] == dict(true="True", false="False")
8787
assert "metrics" not in d
8888

89+
def test_deprecated_set_meta(self):
90+
s = Span(tracer=None, name="test.span")
91+
s.set_meta("munir-1", "hi")
92+
assert s.get_tag("munir-1") == "hi"
93+
94+
def test_deprecated_set_metas(self):
95+
s = Span(tracer=None, name="test.span")
96+
s.set_metas({"hi-1": "munir"})
97+
assert s.get_tag("hi-1") == "munir"
98+
8999
def test_set_tag_metric(self):
90100
s = Span(tracer=None, name="test.span")
91101

0 commit comments

Comments
 (0)