Skip to content

Commit 8b5d6b8

Browse files
authored
Merge branch '0.17.1-dev' into kyle-verhoog/services-workaround
2 parents 11ff2ef + 15b58db commit 8b5d6b8

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

ddtrace/contrib/cassandra/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def traced_start_fetching_next_page(func, instance, args, kwargs):
106106
setattr(instance, CURRENT_SPAN, span)
107107
try:
108108
return func(*args, **kwargs)
109-
except:
109+
except Exception:
110110
with span:
111111
span.set_exc_info(*sys.exc_info())
112112
raise
@@ -161,7 +161,7 @@ def traced_execute_async(func, instance, args, kwargs):
161161
)
162162
result.clear_callbacks()
163163
return result
164-
except:
164+
except Exception:
165165
with span:
166166
span.set_exc_info(*sys.exc_info())
167167
raise

ddtrace/contrib/grpc/client_interceptor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def intercept_unary_stream(self, continuation, client_call_details, request):
3434
new_details = inject_span(span, client_call_details)
3535
try:
3636
return continuation(new_details, request)
37-
except:
37+
except Exception:
3838
span.set_traceback()
3939
raise
4040

@@ -48,6 +48,6 @@ def intercept_stream_stream(self, continuation, client_call_details, request_ite
4848
new_details = inject_span(span, client_call_details)
4949
try:
5050
return continuation(new_details, request_iterator)
51-
except:
51+
except Exception:
5252
span.set_traceback()
5353
raise

ddtrace/contrib/pylons/middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def _start_response(status, *args, **kwargs):
7373
code = int(code)
7474
if not 100 <= code < 600:
7575
code = 500
76-
except:
76+
except Exception:
7777
code = 500
7878
span.set_tag(http.STATUS_CODE, code)
7979
span.error = 1

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ deps=
372372
ignore_outcome=true
373373

374374
[testenv:flake8]
375-
deps=flake8==3.2.0
375+
deps=flake8==3.5.0
376376
commands=flake8 ddtrace
377377
basepython=python2
378378

0 commit comments

Comments
 (0)