You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(ci_visibility): fixes unittest enabling the CI VIsibility plugin [backport 2.1] (#7301)
Backport 02b0eeb from #7292 to 2.1.
## Motivation
This PR aims to fix [this GitHub
issue](#7257) from
dd-trace-py, which was causing unexpected log messages. Related JIRA
issue:
[CIVIS-7652](https://datadoghq.atlassian.net/browse/CIVIS-7652?atlOrigin=eyJpIjoiM2EyMTI2YzY5YWI3NDBiMGI5OWE2ODk3MzE1Nzc2ZDUiLCJwIjoiaiJ9).
## Changes
Now, the `unittest` integration will enable `CIVisibility` only if
`unittest` is running any tests. This will prevent log messages as
CIVisibility won't be enabled until tests are detected.
## Checklist
- [X] Change(s) are motivated and described in the PR description.
- [X] Testing strategy is described if automated tests are not included
in the PR.
- [X] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [X] Change is maintainable (easy to change, telemetry, documentation).
- [X] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [X] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [X] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.
[CIVIS-7652]:
https://datadoghq.atlassian.net/browse/CIVIS-7652?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Co-authored-by: Eric Navarro <[email protected]>
0 commit comments