Skip to content

Commit 93415f8

Browse files
fix(debugging): use the correct span decoration probe type name [backport 1.17] (#6455)
Backport 7ed558e from #6417 to 1.17. Fixed the name of the type of span decoration probes that is used in remote configuration payloads which did not match what the library was expecting. Fixes #6415. ## Testing Strategy Automated testing requires a mocking of RCM and the payloads that it delivers. This will be implemented in future work with system tests. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Gabriele N. Tornetta <[email protected]>
1 parent e9d4695 commit 93415f8

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

ddtrace/debugging/_probe/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,4 +301,4 @@ class ProbeType(object):
301301
LOG_PROBE = "LOG_PROBE"
302302
METRIC_PROBE = "METRIC_PROBE"
303303
SPAN_PROBE = "SPAN_PROBE"
304-
SPAN_DECORATE_PROBE = "SPAN_DECORATE_PROBE"
304+
SPAN_DECORATION_PROBE = "SPAN_DECORATION_PROBE"

ddtrace/debugging/_probe/remoteconfig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ def build_probe(attribs):
263263
return MetricProbeFactory.build(args, attribs)
264264
if _type == ProbeType.SPAN_PROBE:
265265
return SpanProbeFactory.build(args, attribs)
266-
if _type == ProbeType.SPAN_DECORATE_PROBE:
266+
if _type == ProbeType.SPAN_DECORATION_PROBE:
267267
return SpanDecorationProbeFactory.build(args, attribs)
268268

269269
raise ValueError("Unsupported probe type: %s" % _type)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
dynamic instrumentation: fixed a bug that prevented span decoration probes
5+
from being received and instrumented.

0 commit comments

Comments
 (0)