Skip to content

Commit 94fa3cf

Browse files
ci(release): ensure promote-oci-* jobs have necessary artifacts [backport 3.2] (#12661)
Backport b89594b from #12659 to 3.2. v3.2.0 release failed to publish the OCI images because it did not properly inherit the artifacts from the `package-oci` job. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <[email protected]>
1 parent 7b7acbe commit 94fa3cf

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

.gitlab-ci.yml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,22 @@ promote-oci-to-prod:
8989
rules: null
9090
only:
9191
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
92-
needs: [ release_pypi_prod ]
92+
needs:
93+
- job: release_pypi_prod
94+
- job: package-oci
95+
artifacts: true
9396

9497
promote-oci-to-prod-beta:
9598
stage: release
96-
needs: null
99+
needs:
100+
- job: package-oci
101+
artifacts: true
97102

98103
promote-oci-to-staging:
99104
stage: release
100-
needs: null
105+
needs:
106+
- job: package-oci
107+
artifacts: true
101108

102109
publish-lib-init-ghcr-tags:
103110
stage: release
@@ -111,7 +118,10 @@ publish-lib-init-pinned-tags:
111118
rules: null
112119
only:
113120
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
114-
needs: [release_pypi_prod]
121+
needs:
122+
- job: release_pypi_prod
123+
- job: oci-internal-publish
124+
artifacts: true
115125

116126
onboarding_tests_installer:
117127
parallel:

0 commit comments

Comments
 (0)