Skip to content

Commit 9bbcb62

Browse files
chore(ci): ensure we run tracer tests on llmobs changes [backport 2.9] (#9463)
Backport 6adb3e7 from #9455 to 2.9. Ensure we run tracer tests whenever we make changes to llmobs. This would have caught this failing test, which did not run on #9449 https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/62935/workflows/f6fd3f80-bbf7-46cc-b4ee-189f49578fc8/jobs/3917045 ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <[email protected]>
1 parent 543a6d9 commit 9bbcb62

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

tests/.suitespec.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -463,6 +463,7 @@
463463
"@bootstrap",
464464
"@core",
465465
"@contrib",
466+
"@llmobs",
466467
"@serverless",
467468
"@remoteconfig",
468469
"tests/tracer/*",

tests/tracer/test_propagation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2727,7 +2727,7 @@ def test_llmobs_enabled_does_not_inject_parent_id_if_no_llm_span(run_python_code
27272727
headers = {}
27282728
HTTPPropagator.inject(child_span.context, headers)
27292729
2730-
assert "{}".format(PROPAGATED_PARENT_ID_KEY) not in headers["x-datadog-tags"]
2730+
assert f"{PROPAGATED_PARENT_ID_KEY}=undefined" in headers["x-datadog-tags"]
27312731
"""
27322732

27332733
env = os.environ.copy()

0 commit comments

Comments
 (0)