Skip to content

Commit 9d35c2b

Browse files
authored
ci(benchmarks): increase slos for telemetry add metric (#14301)
We've seen some flakiness in a few telemetry add metric benchmarks, increasing the SLOs slightly to give some head room to try and avoid false positives. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent da30538 commit 9d35c2b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,19 +1094,19 @@ experiments:
10941094
- max_rss_usage < 34.00 MB
10951095
- name: telemetryaddmetric-100-count-metrics-100-times
10961096
thresholds:
1097-
- execution_time < 22.50 ms
1097+
- execution_time < 23.00 ms
10981098
- max_rss_usage < 34.00 MB
10991099
- name: telemetryaddmetric-100-distribution-metrics-100-times
11001100
thresholds:
1101-
- execution_time < 2.10 ms
1101+
- execution_time < 2.20 ms
11021102
- max_rss_usage < 34.00 MB
11031103
- name: telemetryaddmetric-100-gauge-metrics-100-times
11041104
thresholds:
1105-
- execution_time < 1.40 ms
1105+
- execution_time < 1.50 ms
11061106
- max_rss_usage < 34.00 MB
11071107
- name: telemetryaddmetric-100-rate-metrics-100-times
11081108
thresholds:
1109-
- execution_time < 2.40 ms
1109+
- execution_time < 2.50 ms
11101110
- max_rss_usage < 34.00 MB
11111111
- name: telemetryaddmetric-flush-1-metric
11121112
thresholds:
@@ -1118,7 +1118,7 @@ experiments:
11181118
- max_rss_usage < 34.00 MB
11191119
- name: telemetryaddmetric-flush-1000-metrics
11201120
thresholds:
1121-
- execution_time < 2.35 ms
1121+
- execution_time < 2.45 ms
11221122
- max_rss_usage < 34.50 MB
11231123

11241124
# tracer

0 commit comments

Comments
 (0)