Fix handling of FetchTracedCursor

Author: majorgreys

ddtrace/contrib/dbapi/__init__.py

@@ -51,7 +51,7 @@ def _trace_method(self, method, name, resource, extra_tags, *args, **kwargs):
             s.set_tags(extra_tags)
 
             # set analytics sample rate if enabled but only for non-FetchTracedCursor
-            if type(self) is not FetchTracedCursor:
+            if not isinstance(self, FetchTracedCursor):
                 s.set_tag(
                     ANALYTICS_SAMPLE_RATE_KEY,
                     config.dbapi2.get_analytics_sample_rate()

tests/contrib/dbapi/test_unit.py

@@ -415,7 +415,8 @@ def method():
         assert span.get_metric('db.rowcount') == 123, 'Row count is set as a metric'
         assert span.get_tag('sql.rows') == '123', 'Row count is set as a tag (for legacy django cursor replacement)'
 
-    def test_fetch_analytics_off(self):
+    def test_fetch_no_analytics(self):
+        """ Confirm fetch* methods do not have analytics sample rate metric """
         with self.override_config(
                 'dbapi2',
                 dict(analytics_enabled=True)