Skip to content

Commit a5f4383

Browse files
authored
fix(profiling): upgrades echion to pick up critical bug fixes and performance improvements (#14476)
Upgrades echion from 3be1d5 to 158a50, see comparison [here](P403n1x87/echion@3be1d56...158a50f) Highlight of changes - P403n1x87/echion#124 - P403n1x87/echion#123 - P403n1x87/echion#127 - P403n1x87/echion#131 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 0103e2f commit a5f4383

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ endif()
4141

4242
# Add echion
4343
set(ECHION_COMMIT
44-
"3be1d5659034796c84b79ad5adb6baf64faf9220" # https://github.com/P403n1x87/echion/commit/3be1d5659034796c84b79ad5adb6baf64faf9220
44+
"158a50f5bba99bce486b007d4c5ee586836610db" # https://github.com/P403n1x87/echion/commit/158a50f5bba99bce486b007d4c5ee586836610db
4545
CACHE STRING "Commit hash of echion to use")
4646
FetchContent_Declare(
4747
echion

ddtrace/internal/datadog/profiling/stack_v2/src/sampler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ Sampler::sampling_thread(const uint64_t seq_num)
151151
sample_time_prev = sample_time_now;
152152

153153
// Perform the sample
154-
for_each_interp([&](PyInterpreterState* interp) -> void {
154+
for_each_interp([&](InterpreterInfo& interp) -> void {
155155
for_each_thread(interp, [&](PyThreadState* tstate, ThreadInfo& thread) {
156-
thread.sample(interp->id, tstate, wall_time_us);
156+
thread.sample(interp.id, tstate, wall_time_us);
157157
});
158158
});
159159

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
profiling: Upgrades echion to pick up critical bug fixes and performance
5+
improvements.

0 commit comments

Comments
 (0)