You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci(opentelemetry): pin cattrs and otel-flask-instrumentation (#7682)
## Description
Unblocks ci by pinning `otel-flask-instrumentation` to `<0.37b0` and
cattrs to `<23.1.0`.
## Motivation
The otel entry point is no longer set after [cattrs
v23.2.0](https://pypi.org/project/cattrs/23.2.1/) was released:
https://github.com/DataDog/dd-trace-py/blob/3aad54003c1f2f2f43680f486f0ac7910f486f77/setup.py#L620
This likely occurred due to errors installing otel dependencies or
generating ddtrace package metadata. Bumping all otel tests to use
[cattrs<23.2.0](0c14b3a#diff-8c2dff2cbcc0f4fff63050381d4c7546ae7195383ec8f9cc993f8494b77a34c3)
resolved this issue.
Note - Using``opentelemetry-instrumentation-flask==latest`` causes this
new test to fail:
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/50865/workflows/fa93192c-5b97-4624-a920-af07e73ac0f3/jobs/3252732.
This PR pins this package to `0.37b0` to unblock ci.
## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.
Co-authored-by: Brett Langdon <[email protected]>
0 commit comments