Merge pull request #50 from DataDog/matt/info

sqlalchemy: set service info

Author: clutchski

ddtrace/contrib/sqlalchemy/engine.py

@@ -43,6 +43,12 @@ def __init__(self, tracer, service, engine):
         self.service = service or self.vendor
         self.name = "%s.query" % self.vendor
 
+        # set the service info.
+        self.tracer.set_service_info(
+            service=self.service,
+            app=self.vendor,
+            app_type=sqlx.APP_TYPE)
+
         self._span_buffer = ThreadLocalSpanBuffer()
 
         listen(engine, 'before_cursor_execute', self._before_cur_exec)

ddtrace/ext/sql.py

@@ -1,6 +1,10 @@
 
+from ddtrace.ext import AppTypes
+
+
 # the type of the spans
 TYPE = "sql"
+APP_TYPE = AppTypes.db
 
 # tags
 QUERY = "sql.query"   # the query text

tests/contrib/sqlalchemy/test.py

@@ -160,3 +160,11 @@ def _connect():
 
     for i in expected:
         assert i in by_rsc, "%s not in %s" % (i, by_rsc.keys())
+
+    # ensure we have the service types
+    services = tracer.writer.pop_services()
+    expected = {
+        service : {"app":vendor, "app_type":"db"}
+    }
+    eq_(services, expected)
+