fix(profiler): support for latest protobuf versions [backport #5664 to 1.13] (#5668)

Backport of #5664 to 1.13

Version 4.21 of the Python protobuf package introduced the [upb C
backend](https://github.com/protocolbuffers/protobuf/tree/main/python#implementation-backends).
The protobuf sources where generated by the 3.19 version of the
compiler, so there are good chances that the latest protobuf releases
are not well-supported by the profiler. In this change we re-compile the
pprof protobuf spec with the latest 21 protoc compiler.

## Testing strategy

No issues have been reported by CI that can be related to a lack of
support for latest versions of protobuf. Therefore it is unclear how to
test for possible incompatibility issues.

## Risk

Support for different protobuf versions remain too coarse and prone to
potential future incompatibilities. This problem will be resolved by the
introduction of libdatadog which will delegate pprof generation to a
native layer that allows us to drop the dependency on the Python
protobuf package.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] PR description includes explicit acknowledgement/acceptance of the
performance implications of this PR as reported in the benchmarks PR
comment.

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

Author: P403n1x87

ddtrace/profiling/exporter/pprof.pyx

@@ -94,14 +94,18 @@ def _protobuf_version():
     return parse_version(google.protobuf.__version__)
 
 
+# Load the appropriate pprof_pb2 module
 _pb_version = _protobuf_version()
-
-if _pb_version >= (3, 19, 0):
-    from ddtrace.profiling.exporter import pprof_pb2
-elif _pb_version >= (3, 12, 0):
-    from ddtrace.profiling.exporter import pprof_pre319_pb2 as pprof_pb2  # type: ignore[no-redef]
+for v in [(4, 21), (3, 19), (3, 12)]:
+    if _pb_version >= v:
+        import sys
+        
+        pprof_module = "ddtrace.profiling.exporter.pprof_%s%s_pb2" % v
+        __import__(pprof_module)
+        pprof_pb2 = sys.modules[pprof_module]
+        break
 else:
-    from ddtrace.profiling.exporter import pprof_pre312_pb2 as pprof_pb2  # type: ignore[no-redef]
+    from ddtrace.profiling.exporter import pprof_3_pb2 as pprof_pb2  # type: ignore[no-redef]
 
 
 _ITEMGETTER_ZERO = operator.itemgetter(0)

ddtrace/profiling/exporter/pprof_pre319_pb2.py renamed to ddtrace/profiling/exporter/pprof_312_pb2.py

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    profiler: Fix support for latest versions of protobuf.

ddtrace/profiling/exporter/pprof_pb2.py renamed to ddtrace/profiling/exporter/pprof_319_pb2.py

@@ -18,11 +18,14 @@ ignore_errors = true
 [mypy-ddtrace.vendor.*]
 ignore_errors = true
 
-[mypy-ddtrace.profiling.exporter.pprof_pb2]
+[mypy-ddtrace.profiling.exporter.pprof_3_pb2]
 ignore_errors = true
 
-[mypy-ddtrace.profiling.exporter.pprof_pre312_pb2]
+[mypy-ddtrace.profiling.exporter.pprof_312_pb2]
 ignore_errors = true
 
-[mypy-ddtrace.profiling.exporter.pprof_pre319_pb2]
+[mypy-ddtrace.profiling.exporter.pprof_319_pb2]
+ignore_errors = true
+
+[mypy-ddtrace.profiling.exporter.pprof_421_pb2]
 ignore_errors = true

ddtrace/profiling/exporter/pprof_pre312_pb2.py renamed to ddtrace/profiling/exporter/pprof_3_pb2.py

@@ -31,7 +31,7 @@ exclude = '''
   | ddtrace/profiling/collector/_task.pyx$
   | ddtrace/profiling/_threading.pyx$
   | ddtrace/profiling/collector/stack.pyx$
-  | ddtrace/profiling/exporter/pprof_.*pb2.py$
+  | ddtrace/profiling/exporter/pprof_.*_pb2.py$
   | ddtrace/profiling/exporter/pprof.pyx$
   | ddtrace/vendor/
   | \.eggs
@@ -69,8 +69,10 @@ exclude-modules = '''
   | ddtrace.profiling.bootstrap.sitecustomize
   | ddtrace.profiling.auto
   # protobuf file fails to import
-  | ddtrace.profiling.exporter.pprof_pre312_pb2
-  | ddtrace.profiling.exporter.pprof_pre319_pb2
+  | ddtrace.profiling.exporter.pprof_3_pb2
+  | ddtrace.profiling.exporter.pprof_312_pb2
+  | ddtrace.profiling.exporter.pprof_319_pb2
+  | ddtrace.profiling.exporter.pprof_421_pb2
   # TODO: resolve slot inheritance issues with profiling
   | ddtrace.profiling.collector
   | ddtrace.appsec.ddwaf.ddwaf_types

ddtrace/profiling/exporter/pprof_421_pb2.py

@@ -15,9 +15,10 @@ exclude=
   ddtrace/__init__.py,
   # We shouldn't lint our vendored dependencies
   ddtrace/vendor/*
-  ddtrace/profiling/exporter/pprof_pb2.py
-  ddtrace/profiling/exporter/pprof_pre319_pb2.py
-  ddtrace/profiling/exporter/pprof_pre312_pb2.py
+  ddtrace/profiling/exporter/pprof_3_pb2.py
+  ddtrace/profiling/exporter/pprof_312_pb2.py
+  ddtrace/profiling/exporter/pprof_319_pb2.py
+  ddtrace/profiling/exporter/pprof_421_pb2.py
   tests/profiling/simple_program_gevent.py
   tests/contrib/grpc/hello_pb2.py