Skip to content

Commit b904e48

Browse files
ci: fix missing paths in suitespec for CI Visibility-related jobs [backport 1.20] (#8380)
Backport 06170ca from #8349 1.20. This fixes the fact that some of the CI Visibility-related files were not covered by suite specs. `git` and `ci` are being added as components because, for example, they are imported by other things: ``` ddtrace/internal/gitmetadata.py 5:from ddtrace.ext.ci import _filter_sensitive_info 6:from ddtrace.ext.git import COMMIT_SHA 7:from ddtrace.ext.git import MAIN_PACKAGE 8:from ddtrace.ext.git import REPOSITORY_URL ``` or ``` ddtrace/profiling/exporter/http.py 18:from ddtrace.ext.git import COMMIT_SHA 19:from ddtrace.ext.git import MAIN_PACKAGE 20:from ddtrace.ext.git import REPOSITORY_URL ``` ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent ef28d89 commit b904e48

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

tests/.suitespec.json

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@
9191
"ddtrace/settings/dynamic_instrumentation.py",
9292
"ddtrace/settings/exception_debugging.py"
9393
],
94+
"ci": [
95+
"ddtrace/ext/ci.py"
96+
],
9497
"ci_visibility": [
9598
"ddtrace/internal/ci_visibility/*",
9699
"ddtrace/ext/test.py"
@@ -123,6 +126,9 @@
123126
"gevent": [
124127
"ddtrace/contrib/gevent/*"
125128
],
129+
"git": [
130+
"ddtrace/ext/git.py"
131+
],
126132
"graphene": [
127133
"ddtrace/contrib/graphene/*"
128134
],
@@ -301,7 +307,8 @@
301307
],
302308
"pytest": [
303309
"ddtrace/contrib/pytest/*",
304-
"ddtrace/contrib/pytest_bdd/*"
310+
"ddtrace/contrib/pytest_bdd/*",
311+
"ddtrace/contrib/pytest_benchmark/*"
305312
],
306313
"unittest": [
307314
"ddtrace/contrib/unittest/*"
@@ -409,6 +416,8 @@
409416
"@core",
410417
"@tracing",
411418
"@ci_visibility",
419+
"@ci",
420+
"@git",
412421
"@pytest",
413422
"tests/ci_visibility/*"
414423
],
@@ -816,13 +825,17 @@
816825
"@tracing",
817826
"@pytest",
818827
"@ci_visibility",
819-
"tests/contrib/pytest/*"
828+
"tests/contrib/pytest/*",
829+
"tests/contrib/pytest_benchmark/*",
830+
"tests/contrib/pytest_bdd/*",
831+
"tests/snapshots/tests.contrib.pytest.*"
820832
],
821833
"unittest": [
822834
"@contrib",
823835
"@unittest",
824836
"@ci_visibility",
825-
"tests/contrib/unittest_plugin/*"
837+
"tests/contrib/unittest_plugin/*",
838+
"tests/snapshots/tests.contrib.unittest.*"
826839
],
827840
"asynctest": [
828841
"@bootstrap",
@@ -832,14 +845,6 @@
832845
"@asynctest",
833846
"tests/contrib/asynctest/*"
834847
],
835-
"pytestbdd": [
836-
"@bootstrap",
837-
"@core",
838-
"@contrib",
839-
"@tracing",
840-
"@pytest",
841-
"tests/contrib/pytest_bdd/*"
842-
],
843848
"pymemcache": [
844849
"@bootstrap",
845850
"@core",

0 commit comments

Comments
 (0)