Skip to content

Commit bf2a622

Browse files
committed
pylibmc: add clarifying comments
1 parent 2558e93 commit bf2a622

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

ddtrace/contrib/pylibmc/addrs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
translate_server_specs = None
44

55
try:
6+
# NOTE: we rely on an undocumented method to parse addresses,
7+
# so be a bit defensive and don't assume it exists.
68
from pylibmc.client import translate_server_specs
79
except ImportError:
810
pass

tests/contrib/flask_cache/test_wrapper_safety.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,4 +228,5 @@ def test_memcached_cache_tracing_with_a_wrong_connection(self):
228228
eq_(span.meta[net.TARGET_HOST], 'localhost')
229229
eq_(span.meta[net.TARGET_PORT], '22230')
230230

231-
# pylibmc raises an exception, memcached doesn't, so don't test that.
231+
# the pylibmc backend raises an exception and memcached backend does
232+
# not, so don't test anything about the status.

0 commit comments

Comments
 (0)