Skip to content

Commit c096e80

Browse files
author
Emanuele Palazzetti
committed
[django] fix test compatibility for Django 2.0
1 parent e452952 commit c096e80

File tree

5 files changed

+36
-4
lines changed

5 files changed

+36
-4
lines changed

tests/contrib/django/app/settings.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
},
7070
]
7171

72-
if django.VERSION >= (1, 10):
72+
if (1, 10) <= django.VERSION < (2, 0):
7373
MIDDLEWARE = [
7474
'django.contrib.sessions.middleware.SessionMiddleware',
7575
'django.middleware.common.CommonMiddleware',
@@ -82,6 +82,21 @@
8282

8383
'tests.contrib.django.app.middlewares.CatchExceptionMiddleware',
8484
]
85+
86+
# Django 2.0 has different defaults
87+
if django.VERSION >= (2, 0):
88+
MIDDLEWARE = [
89+
'django.contrib.sessions.middleware.SessionMiddleware',
90+
'django.middleware.common.CommonMiddleware',
91+
'django.middleware.csrf.CsrfViewMiddleware',
92+
'django.contrib.auth.middleware.AuthenticationMiddleware',
93+
'django.contrib.messages.middleware.MessageMiddleware',
94+
'django.middleware.clickjacking.XFrameOptionsMiddleware',
95+
'django.middleware.security.SecurityMiddleware',
96+
97+
'tests.contrib.django.app.middlewares.CatchExceptionMiddleware',
98+
]
99+
85100
# Always add the legacy conf to make sure we handle it properly
86101
# Pre 1.10 style
87102
MIDDLEWARE_CLASSES = [

tests/contrib/django/compat.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
try:
2+
from django.core.urlresolvers import reverse
3+
except ImportError:
4+
from django.urls import reverse

tests/contrib/django/test_cache_views.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
# 3rd party
44
from nose.tools import eq_, ok_
55

6-
from django.core.urlresolvers import reverse
7-
86
# testing
7+
from .compat import reverse
98
from .utils import DjangoTraceTestCase
109

1110

tests/contrib/django/test_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
from nose.tools import eq_
33

44
from django.test import modify_settings
5-
from django.core.urlresolvers import reverse
65

76
# project
87
from ddtrace.constants import SAMPLING_PRIORITY_KEY
98
from ddtrace.contrib.django.conf import settings
109
from ddtrace.contrib.django import TraceMiddleware
1110

1211
# testing
12+
from .compat import reverse
1313
from .utils import DjangoTraceTestCase, override_ddtrace_settings
1414

1515

tests/contrib/djangorestframework/app/settings.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,20 @@
5555
'tests.contrib.django.app.middlewares.CatchExceptionMiddleware',
5656
]
5757

58+
# Django 2.0 has different defaults
59+
if django.VERSION >= (2, 0):
60+
MIDDLEWARE = [
61+
'django.contrib.sessions.middleware.SessionMiddleware',
62+
'django.middleware.common.CommonMiddleware',
63+
'django.middleware.csrf.CsrfViewMiddleware',
64+
'django.contrib.auth.middleware.AuthenticationMiddleware',
65+
'django.contrib.messages.middleware.MessageMiddleware',
66+
'django.middleware.clickjacking.XFrameOptionsMiddleware',
67+
'django.middleware.security.SecurityMiddleware',
68+
69+
'tests.contrib.django.app.middlewares.CatchExceptionMiddleware',
70+
]
71+
5872
# Always add the legacy conf to make sure we handle it properly
5973
# Pre 1.10 style
6074
MIDDLEWARE_CLASSES = [

0 commit comments

Comments
 (0)