Skip to content

Commit c573fb9

Browse files
authored
fix(tests): ignore gpg signing when running git commit from tests (#5642)
When I run the `tracer` tests locally they try to use my gpg key for creating dummy git repos. Instead of blocking on user input/signing for these tests, this change explicitly adds `--no-gpg-sign` to ignore any gpg signing configured. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] PR description includes explicit acknowledgement/acceptance of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
1 parent bb98416 commit c573fb9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ def create_package(directory, pyproject, setup):
326326
_run("git config --local user.name user")
327327
_run("git config --local user.email [email protected]")
328328
_run("git add .")
329-
_run("git commit -m init")
329+
_run("git commit --no-gpg-sign -m init")
330330
_run("git remote add origin https://github.com/companydotcom/repo.git")
331331

332332
yield package_dir

0 commit comments

Comments
 (0)