Skip to content

Commit c5ae598

Browse files
ci(release): ensure promote-oci-* jobs have necessary artifacts [backport 2.21] (#12823)
Backport b89594b from #12659 to 2.21. v2.21.4 release failed to publish the OCI images because it did not properly inherit the artifacts from the package-oci job. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <[email protected]>
1 parent 8d7d3be commit c5ae598

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

.gitlab-ci.yml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,22 @@ promote-oci-to-prod:
5959
rules: null
6060
only:
6161
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
62-
needs: [ release_pypi_prod ]
62+
needs:
63+
- job: release_pypi_prod
64+
- job: package-oci
65+
artifacts: true
6366

6467
promote-oci-to-prod-beta:
6568
stage: release
66-
rules: null
67-
only:
68-
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
69-
needs: null
69+
needs:
70+
- job: package-oci
71+
artifacts: true
7072

7173
promote-oci-to-staging:
7274
stage: release
73-
rules: null
74-
only:
75-
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
76-
needs: null
75+
needs:
76+
- job: package-oci
77+
artifacts: true
7778

7879
publish-lib-init-ghcr-tags:
7980
stage: release
@@ -87,7 +88,10 @@ publish-lib-init-pinned-tags:
8788
rules: null
8889
only:
8990
- /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
90-
needs: [release_pypi_prod]
91+
needs:
92+
- job: release_pypi_prod
93+
- job: oci-internal-publish
94+
artifacts: true
9195

9296
onboarding_tests_installer:
9397
parallel:

0 commit comments

Comments
 (0)