feat(asm): remove telemetry tag (#5648)

Remove telemetry tag until telemetry-intake service enables it

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] PR description includes explicit acknowledgement/acceptance of the
performance implications of this PR as reported in the benchmarks PR
comment.

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

Author: avara1986

ddtrace/appsec/_metrics.py

@@ -68,25 +68,20 @@ def _set_waf_request_metrics():
             is_blocked = any(list_is_blocked)
             is_triggered = any((result.data for result in list_results))
             is_timeout = any((result.timeout for result in list_results))
-            is_truncation = any((result.truncation for result in list_results))
+            # TODO: enable it when Telemetry intake accepts this tag
+            # is_truncation = any((result.truncation for result in list_results))
             has_info = any(list_result_info)
 
-            common_tags = {
+            tags_request = {
                 "waf_version": version(),
                 "rule_triggered": is_triggered,
                 "request_blocked": is_blocked,
                 "waf_timeout": is_timeout,
-                "request_truncated": is_truncation,
+                # "request_truncated": is_truncation,
             }
 
             if has_info and list_result_info[0].version:
-                common_tags["event_rules_version"] = list_result_info[0].version
-
-            tags_request = {
-                "rule_triggered": is_triggered,
-                "request_blocked": is_blocked,
-            }
-            tags_request.update(common_tags)
+                tags_request["event_rules_version"] = list_result_info[0].version
 
             telemetry_metrics_writer.add_count_metric(
                 TELEMETRY_NAMESPACE_TAG_APPSEC,

tests/appsec/test_telemety.py

@@ -49,7 +49,7 @@ def _assert_generate_metrics(metrics_result, is_rule_triggered=False, is_blocked
         if metric.name == "waf.requests":
             assert metric._tags["rule_triggered"] is is_rule_triggered
             assert metric._tags["request_blocked"] is is_blocked_request
-            assert metric._tags["request_truncated"] is False
+            # assert metric._tags["request_truncated"] is False
             assert metric._tags["waf_timeout"] is False
             assert len(metric._tags["waf_version"]) > 0
             assert len(metric._tags["event_rules_version"]) > 0