Skip to content

Commit cb245cd

Browse files
authored
[cassandra] Fix batched query leak (#714)
* [cassandra] use query as resource for batched queries * [cassandra] update batchstatement test * [cassandra] remove query tag
1 parent ca01601 commit cb245cd

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

ddtrace/contrib/cassandra/session.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,7 @@ def _sanitize_query(span, query):
253253
# reset query if a string is available
254254
resource = getattr(query, "query_string", query)
255255
elif t == 'BatchStatement':
256-
resource = 'BatchStatement'
257-
q = "; ".join(q[1] for q in query._statements_and_parameters[:2])
258-
span.set_tag("cassandra.query", q)
256+
resource = '; '.join(q[1] for q in query._statements_and_parameters[:2])
259257
span.set_metric("cassandra.batch_size", len(query._statements_and_parameters))
260258
elif t == 'BoundStatement':
261259
ps = getattr(query, 'prepared_statement', None)

tests/contrib/cassandra/test.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,15 @@ def test_batch_statement(self):
264264
spans = writer.pop()
265265
eq_(len(spans), 1)
266266
s = spans[0]
267-
eq_(s.resource, 'BatchStatement')
267+
eq_(
268+
s.resource,
269+
(
270+
'INSERT INTO test.person_write (name, age, description) VALUES (\'Joe\', 1, \'a\'); '
271+
'INSERT INTO test.person_write (name, age, description) VALUES (\'Jane\', 2, \'b\')'
272+
)
273+
)
268274
eq_(s.get_metric('cassandra.batch_size'), 2)
269-
assert 'test.person' in s.get_tag('cassandra.query')
275+
assert s.get_tag('cassandra.query') is None
270276

271277

272278
class TestCassPatchDefault(CassandraBase):

0 commit comments

Comments
 (0)