[pylons] catch 500s

Author: LeoCavaille

ddtrace/contrib/pylons/middleware.py

@@ -27,6 +27,7 @@ def __call__(self, environ, start_response):
             if not span.sampled:
                 return self.app(environ, start_response)
 
+            # tentative on status code, otherwise will be caught by except below
             def _start_response(status, *args, **kwargs):
                 """ a patched response callback which will pluck some metadata. """
                 http_code = int(status.split()[0])
@@ -37,6 +38,12 @@ def _start_response(status, *args, **kwargs):
 
             try:
                 return self.app(environ, _start_response)
+            except Exception as e:
+                # "unexpected errors"
+                # exc_info set by __exit__ on current tracer
+                span.set_tag(http.STATUS_CODE, getattr(e, 'code', 500))
+                span.error = 1
+                raise
             finally:
                 controller = environ.get('pylons.routes_dict', {}).get('controller')
                 action = environ.get('pylons.routes_dict', {}).get('action')