Skip to content

Commit cf1cf50

Browse files
test: fix parametrisation support in subprocess marker [backport 1.12] (#6089)
Backport 5d174c8 from #6085 to 1.12. A bug in the handling of the parametrize argument to the subprocess marker prevented it from generating the correct test matrix. This fix ensures that the correct matrix dictionary is generated so that all the intended test cases are actually run. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](../docs/contributing.rst#release-branch-maintenance)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](../docs/contributing.rst#release-branch-maintenance) Co-authored-by: Gabriele N. Tornetta <[email protected]>
1 parent 7c064b3 commit cf1cf50

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def unwind_params(params):
142142
yield None
143143
return
144144

145-
for _ in product(*(((k, v) for v in vs) for k, vs in params.items())):
145+
for _ in product(*([(k, v) for v in vs] for k, vs in params.items())):
146146
yield dict(_)
147147

148148

0 commit comments

Comments
 (0)