Fix how bool values from config.yml are parsed for perf benchmarks (#2993)

* Fix boolean parsing in config.yml for perf benchmarks

Boolean values were incorrectly parsed and were always set to True. This bugfix uses code from not yet released attrs 21.3.0 to fix the issue.

* do not shadow built-in 'bool'

Co-authored-by: Brett Langdon <[email protected]>

Author: ddyurchenko

benchmarks/bm/__init__.py

@@ -1,8 +1,10 @@
 from ._scenario import Scenario
 from ._scenario import var
+from ._scenario import var_bool
 
 
 __all__ = [
     "var",
+    "var_bool",
     "Scenario",
 ]

benchmarks/bm/_scenario.py

@@ -5,10 +5,16 @@
 import pyperf
 import six
 
+from ._to_bool import to_bool
+
 
 var = attr.ib
 
 
+def var_bool(*args, **kwargs):
+    return attr.ib(*args, **kwargs, converter=to_bool)
+
+
 def _register(scenario_cls):
     """Registers a scenario for benchmarking."""
     # This extends pyperf's runner by registering arguments for the scenario config

benchmarks/bm/_to_bool.py

@@ -0,0 +1,38 @@
+def to_bool(val):
+    """
+    Copied from
+    https://github.com/python-attrs/attrs/blob/e84b57ea687942e5344badfe41a2728e24037431/src/attr/converters.py#L114
+
+    Please remove after updating attrs to 21.3.0.
+
+    Convert "boolean" strings (e.g., from env. vars.) to real booleans.
+    Values mapping to :code:`True`:
+    - :code:`True`
+    - :code:`"true"` / :code:`"t"`
+    - :code:`"yes"` / :code:`"y"`
+    - :code:`"on"`
+    - :code:`"1"`
+    - :code:`1`
+    Values mapping to :code:`False`:
+    - :code:`False`
+    - :code:`"false"` / :code:`"f"`
+    - :code:`"no"` / :code:`"n"`
+    - :code:`"off"`
+    - :code:`"0"`
+    - :code:`0`
+    :raises ValueError: for any other value.
+    .. versionadded:: 21.3.0
+    """
+    if isinstance(val, str):
+        val = val.lower()
+    truthy = {True, "true", "t", "yes", "y", "on", "1", 1}
+    falsy = {False, "false", "f", "no", "n", "off", "0", 0}
+    try:
+        if val in truthy:
+            return True
+        if val in falsy:
+            return False
+    except TypeError:
+        # Raised when "val" is not hashable (e.g., lists)
+        pass
+    raise ValueError("Cannot convert value to bool: {}".format(val))

benchmarks/django_simple/scenario.py

@@ -3,8 +3,8 @@
 
 
 class DjangoSimple(bm.Scenario):
-    tracer_enabled = bm.var(type=bool)
-    profiler_enabled = bm.var(type=bool)
+    tracer_enabled = bm.var_bool()
+    profiler_enabled = bm.var_bool()
 
     def run(self):
         with utils.server(self) as get_response:

benchmarks/encoder/scenario.py

@@ -8,7 +8,7 @@ class Encoder(bm.Scenario):
     ntags = bm.var(type=int)
     ltags = bm.var(type=int)
     nmetrics = bm.var(type=int)
-    dd_origin = bm.var(type=bool)
+    dd_origin = bm.var_bool()
     encoding = bm.var(type=str)
 
     def run(self):

benchmarks/flask_simple/scenario.py

@@ -3,8 +3,8 @@
 
 
 class FlaskSimple(bm.Scenario):
-    tracer_enabled = bm.var(type=bool)
-    profiler_enabled = bm.var(type=bool)
+    tracer_enabled = bm.var_bool()
+    profiler_enabled = bm.var_bool()
 
     def run(self):
         with utils.server(self) as get_response:

benchmarks/span/scenario.py

@@ -9,7 +9,7 @@ class Span(bm.Scenario):
     ntags = bm.var(type=int)
     ltags = bm.var(type=int)
     nmetrics = bm.var(type=int)
-    finishspan = bm.var(type=bool)
+    finishspan = bm.var_bool()
 
     def run(self):
         # run scenario to also set tags on spans