You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(profiling): add (one of?) the correct classes to lock profiling exporting (#6605)
In testing libdatadog and from recent customer questions, I learned that
lock profiling isn't working the way it should.
Conceptually, profiling works by adding events into a
dictionary-of-lists which is keyed by the name of the inserted class. A
static list of class names is checked later in order to export events
which have been a-priori qualified as "lock" events.
Reviewers may wonder why this wasn't spotted by tests. The tests check
for the presence of instrumentation, not the result of profiling.
This will probably increase overhead at time of export since we'll have
more events to emit.
## Checklist
- [X] Change(s) are motivated and described in the PR description.
- [X] Testing strategy is described if automated tests are not included
in the PR.
- [X] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [X] Change is maintainable (easy to change, telemetry, documentation).
- [X] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [X] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [X] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [X] Title is accurate.
- [X] No unnecessary changes are introduced.
- [X] Description motivates each change.
- [X] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [X] Testing strategy adequately addresses listed risk(s).
- [X] Change is maintainable (easy to change, telemetry, documentation).
- [X] Release note makes sense to a user of the library.
- [X] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [X] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
---------
Co-authored-by: sanchda <[email protected]>
0 commit comments