requests: handle empty paths

Author: clutchski

ddtrace/contrib/requests/patch.py

@@ -57,7 +57,8 @@ def _apply_tags(span, method, url, response):
         parsed = urlparse.urlparse(url)
         span.service = parsed.netloc
         # FIXME[matt] how do we decide how do we normalize arbitrary urls???
-        span.resource = "%s %s" % (method.upper(), parsed.path)
+        path = parsed.path or "/"
+        span.resource = "%s %s" % (method.upper(), path)
     except Exception:
         pass
 

tests/contrib/requests/test_requests.py

@@ -12,8 +12,7 @@
 class TestRequests(object):
 
     @staticmethod
-    def test_resources():
-        # ensure all valid combinations of args / kwargs work
+    def test_resource_path():
         tracer, session = get_traced_session()
         out = session.get('http://httpstat.us/200')
         eq_(out.status_code, 200)
@@ -22,6 +21,23 @@ def test_resources():
         s = spans[0]
         eq_(s.resource, 'GET /200')
 
+    @staticmethod
+    def test_resource_empty_path():
+        tracer, session = get_traced_session()
+        out = session.get('http://httpstat.us')
+        eq_(out.status_code, 200)
+        spans = tracer.writer.pop()
+        eq_(len(spans), 1)
+        s = spans[0]
+        eq_(s.resource, 'GET /')
+
+        out = session.get('http://httpstat.us/')
+        eq_(out.status_code, 200)
+        spans = tracer.writer.pop()
+        eq_(len(spans), 1)
+        s = spans[0]
+        eq_(s.resource, 'GET /')
+
     @staticmethod
     def test_tracer_disabled():
         # ensure all valid combinations of args / kwargs work