Skip to content

Commit d0e50ca

Browse files
authored
chore(ci_visibility): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set (#7656)
## Motivation This PR moves the `_DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE` to the `_should_collect_coverage()` function to override API answers. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that.
1 parent 1116c8d commit d0e50ca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ddtrace/internal/ci_visibility/recorder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,9 @@ def __init__(self, tracer=None, config=None, service=None):
169169

170170
@staticmethod
171171
def _should_collect_coverage(coverage_enabled_by_api):
172-
if not coverage_enabled_by_api:
172+
if not coverage_enabled_by_api and not asbool(
173+
os.getenv("_DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE", default=False)
174+
):
173175
return False
174176
if compat.PY2:
175177
log.warning("CI Visibility code coverage tracking is enabled, but Python 2 is not supported.")
@@ -240,8 +242,6 @@ def _check_enabled_features(self):
240242
return False, False
241243

242244
attributes = parsed["data"]["attributes"]
243-
if asbool(os.getenv("_DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE", default=False)):
244-
return True, attributes["tests_skipping"]
245245
return attributes["code_coverage"], attributes["tests_skipping"]
246246

247247
def _configure_writer(self, coverage_enabled=False, requests_mode=None):

0 commit comments

Comments
 (0)