feat(asm): disable distribution metrics (#5529)

Disable ASM distribution metrics report

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] PR description includes explicit acknowledgement/acceptance of the
performance implications of this PR as reported in the benchmarks PR
comment.

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

---------

Co-authored-by: Federico Mon <[email protected]>

Author: avara1986

ddtrace/appsec/_metrics.py

@@ -79,23 +79,6 @@ def _set_waf_request_metrics():
             if has_info and list_result_info[0].version:
                 common_tags["event_rules_version"] = list_result_info[0].version
 
-            if list_results:
-                # runtime is the result in microseconds. Update to milliseconds
-                ddwaf_result_runtime = sum(float(ddwaf_result.runtime) for ddwaf_result in list_results)
-                ddwaf_result_total_runtime = sum(float(ddwaf_result.runtime) for ddwaf_result in list_results)
-                telemetry_metrics_writer.add_distribution_metric(
-                    TELEMETRY_NAMESPACE_TAG_APPSEC,
-                    "waf.duration",
-                    float(ddwaf_result_runtime / 1e3),
-                    tags=common_tags,
-                )
-                telemetry_metrics_writer.add_distribution_metric(
-                    TELEMETRY_NAMESPACE_TAG_APPSEC,
-                    "waf.duration_ext",
-                    float(ddwaf_result_total_runtime / 1e3),
-                    tags=common_tags,
-                )
-
             tags_request = {
                 "rule_triggered": is_triggered,
                 "request_blocked": is_blocked,
@@ -108,7 +91,6 @@ def _set_waf_request_metrics():
                 1.0,
                 tags=tags_request,
             )
-            # TODO: add log metric to report info.failed and info.errors
     except Exception:
         log.warning("Error reporting ASM WAF requests metrics", exc_info=True)
     finally:

tests/appsec/test_telemety.py

@@ -97,7 +97,6 @@ def test_metrics_when_appsec_runs(mock_telemetry_metrics_writer, tracer):
                 Config(),
             )
     _assert_generate_metrics(mock_telemetry_metrics_writer._namespace._metrics_data)
-    _assert_distributions_metrics(mock_telemetry_metrics_writer._namespace._metrics_data)
 
 
 def test_metrics_when_appsec_attack(mock_telemetry_metrics_writer, tracer):
@@ -109,7 +108,6 @@ def test_metrics_when_appsec_attack(mock_telemetry_metrics_writer, tracer):
         with tracer.trace("test", span_type=SpanTypes.WEB) as span:
             set_http_meta(span, Config(), request_cookies={"attack": "1' or '1' = '1'"})
     _assert_generate_metrics(mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True)
-    _assert_distributions_metrics(mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True)
 
 
 def test_metrics_when_appsec_block(mock_telemetry_metrics_writer, tracer):
@@ -128,9 +126,6 @@ def test_metrics_when_appsec_block(mock_telemetry_metrics_writer, tracer):
     _assert_generate_metrics(
         mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True, is_blocked_request=True
     )
-    _assert_distributions_metrics(
-        mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True, is_blocked_request=True
-    )
 
 
 def test_log_metric_error_ddwaf_init(mock_logs_telemetry_metrics_writer):

tests/contrib/flask/test_flask_appsec_telemetry.py

@@ -8,7 +8,6 @@
 from ddtrace.internal.constants import APPSEC_BLOCKED_RESPONSE_JSON
 from tests.appsec.test_processor import RULES_GOOD_PATH
 from tests.appsec.test_processor import _BLOCKED_IP
-from tests.appsec.test_telemety import _assert_distributions_metrics
 from tests.appsec.test_telemety import _assert_generate_metrics
 from tests.appsec.test_telemety import mock_telemetry_metrics_writer  # noqa: F401
 from tests.contrib.flask import BaseFlaskTestCase
@@ -39,9 +38,6 @@ def test_telemetry_metrics_block(self):
         _assert_generate_metrics(
             self.mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True, is_blocked_request=True
         )
-        _assert_distributions_metrics(
-            self.mock_telemetry_metrics_writer._namespace._metrics_data, is_rule_triggered=True, is_blocked_request=True
-        )
 
     def test_telemetry_metrics_attack(self):
         with override_global_config(dict(_appsec_enabled=True, _telemetry_metrics_enabled=True)):
@@ -58,8 +54,3 @@ def test_telemetry_metrics_attack(self):
             is_rule_triggered=True,
             is_blocked_request=False,
         )
-        _assert_distributions_metrics(
-            self.mock_telemetry_metrics_writer._namespace._metrics_data,
-            is_rule_triggered=True,
-            is_blocked_request=False,
-        )