Skip to content

Commit db87313

Browse files
fix(iast): remove unneeded atexit handler [backport 2.5] (#8595)
Backport 9aaa7d4 from #8565 to 2.5. IAST: This fix addresses an issue where the atexit handler could lead to a segmentation fault. Fixes #8504 ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Federico Mon <[email protected]>
1 parent c03c565 commit db87313

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ddtrace/appsec/_iast/_taint_tracking/_native.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ PYBIND11_MODULE(_native, m)
6363
{
6464
initializer = make_unique<Initializer>();
6565
initializer->create_context();
66-
// Cleanup code to be run at the end of the interpreter lifetime:
67-
auto atexit = py::module::import("atexit");
68-
atexit.attr("register")(py::cpp_function([] { initializer.reset(); }));
6966

7067
m.doc() = "Native Python module";
7168

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
fixes:
3+
- |
4+
Vulnerability Management for Code-level (IAST): Fixes an issue where an atexit handler could lead to a segmentation fault.

0 commit comments

Comments
 (0)