Skip to content

Commit dcfc4ef

Browse files
taegyunkimsanchda
andauthored
fix(profiling): upgrade echion to pick up performance fixes (#13230)
This PR is to pick up following recent PRs on echion - [perf: use cpuclockid in favor of procfs for is_running()](P403n1x87/echion#99) - [fix: 3.11 and 3.12 uses datastack chunk for frame address resolution](P403n1x87/echion#105) - [fix: set origin pointer to make stackchunk useful again](P403n1x87/echion#106) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: David Sanchez <[email protected]>
1 parent 997a12e commit dcfc4ef

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ endif()
4141

4242
# Add echion
4343
set(ECHION_COMMIT
44-
"0876677add34925dbb5beaa7048226fabaddd0df" # https://github.com/P403n1x87/echion/commit/0876677add34925dbb5beaa7048226fabaddd0df
44+
"6ebe7dddb604aa97e89f072c0fc65c9785e023a0" # https://github.com/P403n1x87/echion/commit/6ebe7dddb604aa97e89f072c0fc65c9785e023a0
4545
CACHE STRING "Commit hash of echion to use")
4646
FetchContent_Declare(
4747
echion
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
fixes:
3+
- |
4+
profiling: Upgrades echion to pick up fixes which enables the stack sampler
5+
to avoid extra calls to ``process_vm_readv()`` syscalls for Python frame
6+
objects for Python versions 3.11+.
7+
upgrade:
8+
- |
9+
profiling: Upgrades echion, improving the performance of stack sampler by
10+
replacing proc filesystem reads with ``clock_gettime()``.
11+

0 commit comments

Comments
 (0)