Skip to content

Commit e07a5d0

Browse files
author
Emanuele Palazzetti
committed
[docs] explicit that set_metric() only add a tag
1 parent c2df100 commit e07a5d0

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ddtrace/span.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,10 @@ def set_metas(self, kvs):
152152
self.set_tags(kvs)
153153

154154
def set_metric(self, key, value):
155-
# FIXME[matt] we could push this check to serialization time as well.
155+
# This method sets a numeric tag value for the given key. It acts
156+
# like `set_meta()` and it simply add a tag without further processing.
156157

158+
# FIXME[matt] we could push this check to serialization time as well.
157159
# only permit types that are commonly serializable (don't use
158160
# isinstance so that we convert unserializable types like numpy
159161
# numbers)

0 commit comments

Comments
 (0)